Re: Centering bass figures on whole notes and longer (issue 325070043 by address@hidden)

[thomasmorley65]

On 2017/07/15 08:06:41, richard_rshann.plus.com wrote:

> So I think you could validly object that you didn't like them being
> treated differently.

If you look at the following, namely the colored BassFigures

cbf = \once \override BassFigure.color = #red
<<
  \relative c' { c1 c8 d e f g f e d c1 c1 }
  \figures { <_!>2 <_!>2 \cbf <_!>1 <_!>2 <_!>2 \cbf <_!>1 }


You'll see your patch improves the second colored BassFigure, but the
first one is turned worse.

> But that wouldn't justify sticking with the
> horrible effect you see when there is a single figure/lone accidental.


Indeed. Hence my suggestion to code a callback looking at the related
NoteColumn.



https://codereview.appspot.com/325070043/