Re: Additions in event-listener.ly (issue 152600043 by address@hidden)

[dak]

https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly
File ly/event-listener.ly (right):

https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode69
ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment))
Why this change for the worse?  Numbers need to be compared with eqv?
rather than eq? and I don't see that anything was wrong with zero? here
since ly:moment-grace-numerator certainly cannot return a non-number.

https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode144
ly/event-listener.ly:144: "note"
On 2014/10/17 06:40:24, Valentin Villenave wrote:
> Strictly speaking, this isn't a "note". "Drumnote" may be too long,
how about
> "stroke" or something else?

Well, it's called "drum-type" so what about just "type" here?

https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode251
ly/event-listener.ly:251: (note-event . format-drumnote)
I don't think that having separate engravers for \Voice and \DrumVoice
makes a whole lot of sense.

Instead, format-drumnote likely should get folded into format-note and
the decision for the note format be made on the presence of
pitch/drumtype fields.

https://codereview.appspot.com/152600043/