Re: Fix build failure on GNU Hurd (issue 319400043 by address@hidden)

[pkx166h]

On 2017/03/08 11:43:26, trueroad wrote:
> On 2017/03/04 18:03:37, pkx166h wrote:
> > I am going to need some help from a developer on this as not being a
> programmer
> > I don't know what that last comment means I need to do on my side.

> I've tried Patch Set 1.
> I could not reproduce errors.
> Would you show me your environment and detailed reproduction
procedure?

> I've succeeded the following commands in my environment.

> $ git fetch
> $ git checkout master
> $ git merge origin/master
> $ ./autogen.sh --noconf
> $ rm -fr build
> $ mkdir build
> $ cd build
> $ ../configure
> $ make -j 4 CPU_COUNT=4
> $ make -j 4 CPU_COUNT=4 test-baseline
> $ cd ..
> $ git apply ~/issue319400043_1.diff
> $ cd build
> $ make clean
> $ make -j 4 CPU_COUNT=4

> In another word, the second `make` (after `make clean`) has succeeded.
> However, next command

> $ make -j 4 CPU_COUNT=4 check

> `make check` has failed.

> The cause of the error that occurred in my environment seems to be
multiple
> definition of the same name function.
> I think that it is easy to fix.

> But, the error that occurred in your environment is unknown.

Hello Hosoda-san,

My error message is similar it is this:

rm -f ./out/test-std.dep; DEPENDENCIES_OUTPUT="./out/test-std.dep
./out/test-std.o" g++ -c   -I/usr/include/python2.7
-I/usr/include/x86_64-linux-gnu/python2.7  -fno-strict-aliasing -g
-fstack-protector-strong  -g -fwrapv  -DHAVE_CONFIG_H  -DDEBUG
-I/home/jlowe/lilypond-git/flower/include -I./out
-I/home/jlowe/lilypond-git/flower/include -I../flower/./out
-I/home/jlowe/lilypond-git/flower/out  -g -pipe -pthread
-I/usr/include/freetype2 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-W -Wall -Wconversion -o out/test-std.o
/home/jlowe/lilypond-git/flower/test-std.cc
In file included from
/home/jlowe/lilypond-git/flower/test-file-path.cc:6:0:
/home/jlowe/lilypond-git/flower/include/yaffut.hh: In member function
'int yaffut::Factory::Main(int, const char**)':
/home/jlowe/lilypond-git/flower/include/yaffut.hh:212:39: warning:
conversion to 'int' from 'size_t {aka long unsigned int}' may alter its
value [-Wconversion]
     return Factory::Instance ().Fail ();
                                       ^
In file included from
/home/jlowe/lilypond-git/flower/include/yaffut-parameters.hh:4:0,
                 from
/home/jlowe/lilypond-git/flower/test-file-name.cc:3:
/home/jlowe/lilypond-git/flower/include/yaffut.hh: In member function
'int yaffut::Factory::Main(int, const char**)':
/home/jlowe/lilypond-git/flower/include/yaffut.hh:212:39: warning:
conversion to 'int' from 'size_t {aka long unsigned int}' may alter its
value [-Wconversion]
     return Factory::Instance ().Fail ();
                                       ^
In file included from
/home/jlowe/lilypond-git/flower/test-string.cc:6:0:
/home/jlowe/lilypond-git/flower/include/yaffut.hh: In member function
'int yaffut::Factory::Main(int, const char**)':
/home/jlowe/lilypond-git/flower/include/yaffut.hh:212:39: warning:
conversion to 'int' from 'size_t {aka long unsigned int}' may alter its
value [-Wconversion]
     return Factory::Instance ().Fail ();
                                       ^
In file included from /home/jlowe/lilypond-git/flower/test-std.cc:7:0:
/home/jlowe/lilypond-git/flower/include/yaffut.hh: In member function
'int yaffut::Factory::Main(int, const char**)':
/home/jlowe/lilypond-git/flower/include/yaffut.hh:212:39: warning:
conversion to 'int' from 'size_t {aka long unsigned int}' may alter its
value [-Wconversion]
     return Factory::Instance ().Fail ();
                                       ^
rm -f ./out/test-interval-set.dep;
DEPENDENCIES_OUTPUT="./out/test-interval-set.dep
./out/test-interval-set.o" g++ -c   -I/usr/include/python2.7
-I/usr/include/x86_64-linux-gnu/python2.7  -fno-strict-aliasing -g
-fstack-protector-strong  -g -fwrapv  -DHAVE_CONFIG_H  -DDEBUG
-I/home/jlowe/lilypond-git/flower/include -I./out
-I/home/jlowe/lilypond-git/flower/include -I../flower/./out
-I/home/jlowe/lilypond-git/flower/out  -g -pipe -pthread
-I/usr/include/freetype2 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-W -Wall -Wconversion -o out/test-interval-set.o
/home/jlowe/lilypond-git/flower/test-interval-set.cc
In file included from
/home/jlowe/lilypond-git/flower/test-interval-set.cc:22:0:
/home/jlowe/lilypond-git/flower/include/yaffut.hh: In member function
'int yaffut::Factory::Main(int, const char**)':
/home/jlowe/lilypond-git/flower/include/yaffut.hh:212:39: warning:
conversion to 'int' from 'size_t {aka long unsigned int}' may alter its
value [-Wconversion]
     return Factory::Instance ().Fail ();
                                       ^
/home/jlowe/lilypond-git/flower/include/yaffut.hh: In instantiation of
'void yaffut::equal(const Expected&, const Actual&, const char*, const
char*) [with Expected = long unsigned int; Actual = int]':
/home/jlowe/lilypond-git/flower/test-interval-set.cc:35:3:   required
from here
/home/jlowe/lilypond-git/flower/include/yaffut.hh:326:9: warning:
comparison between signed and unsigned integer expressions
[-Wsign-compare]
   if (e != a)
         ^
make -C ../flower &&  true
make[2]: Entering directory '/home/jlowe/lilypond-git/build/flower'
true
make[2]: Leaving directory '/home/jlowe/lilypond-git/build/flower'
g++ -o out/test-flower ./out/test-file-name.o ./out/test-string.o
./out/test-file-path.o ./out/test-std.o ./out/test-interval-set.o
./out/../../flower/out/library.a
./out/../../flower/out/library.a(file-name.o): In function
`get_working_directory[abi:cxx11]()':
/home/jlowe/lilypond-git/flower/file-name.cc:79: multiple definition of
`get_working_directory[abi:cxx11]()'
./out/test-file-path.o:/home/jlowe/lilypond-git/flower/test-file-path.cc:11:
first defined here
collect2: error: ld returned 1 exit status
/home/jlowe/lilypond-git/stepmake/stepmake/test-rules.make:10: recipe
for target 'out/test-flower' failed
make[1]: *** [out/test-flower] Error 1
make[1]: Leaving directory '/home/jlowe/lilypond-git/build/flower'
/home/jlowe/lilypond-git/stepmake/stepmake/generic-targets.make:141:
recipe for target 'check' failed
make: *** [check] Error 2




https://codereview.appspot.com/319400043/