lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

apply sign on orientation in make-bow-stencil (issue 285770043 by addres


From: thomasmorley65
Subject: apply sign on orientation in make-bow-stencil (issue 285770043 by address@hidden)
Date: Wed, 06 Jan 2016 18:05:41 +0000

Reviewers: ,

Message:
Please review

Description:
apply sign on orientation in make-bow-stencil

This avoids ambiguity with bow-height and thickness

Please review this at https://codereview.appspot.com/285770043/

Affected files (+2, -4 lines):
  M scm/stencil.scm


Index: scm/stencil.scm
diff --git a/scm/stencil.scm b/scm/stencil.scm
index bec03016505e4cc5317061f08d2b80f5e416e53f..71d613c9f4caf23724c2ac3d33d245ef65775b94 100644
--- a/scm/stencil.scm
+++ b/scm/stencil.scm
@@ -49,8 +49,6 @@ The higher the value of number @var{angularity}, the more angular the shape of
 the bow.
 @var{bow-height} determines the height of the bow.
 @var{orientation} determines, whether the bow is concave or convex.
address@hidden should be set to @val{-1} or @val{1}, other values are
-possible but will affect the bow's height as well.
 Both variables are supplied to support independent usage.

Done by calculating a horizontal unit-bow first, then moving all control-points
@@ -77,9 +75,9 @@ Limitation: s-curves are currently not supported.
           ;;;; (1) calculate control-points for the horizontal unit-bow,
                ;; y-values for 2nd/3rd control-points
                (outer-control
-                 (* 4/3 orientation (/ bow-height length-to-print)))
+                 (* 4/3 (sign orientation) (/ bow-height length-to-print)))
                (inner-control
-                 (* orientation
+                 (* (sign orientation)
                     (- (abs outer-control) (/ thickness length-to-print))))
;; x-values for 2nd/3rd control-points depending on `angularity'
                (offset-index





reply via email to

[Prev in Thread] Current Thread [Next in Thread]