lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NR 3.3.2: nitpicks in lily example (issue 284060044 by address@hidden)


From: simon . albrecht
Subject: NR 3.3.2: nitpicks in lily example (issue 284060044 by address@hidden)
Date: Sun, 03 Jan 2016 22:57:24 +0000

Reviewers: ,

Message:
Sorry, I made a mess and had to create a new Rietveld issue. I’m not
quite familiar with the process yet…

Well, this is to Harm’s comments.
I wasn’t quite sure about indenting arguments to \partcombine, but I
prefer having all in one line anyway.

Description:
NR 3.3.2: nitpicks in lily example

add a missing space
better code formatting with \partcombine
remove printPartCombineTexts setting

Please review this at https://codereview.appspot.com/284060044/

Affected files (+3, -9 lines):
  M Documentation/notation/input.itely


Index: Documentation/notation/input.itely
diff --git a/Documentation/notation/input.itely b/Documentation/notation/input.itely index 768fab6841c563696285c4d17854804bd2af49e6..ccfad7c9a70c32b5a69914df692a02e27cb72f0f 100644
--- a/Documentation/notation/input.itely
+++ b/Documentation/notation/input.itely
@@ -2126,7 +2126,7 @@ sopranoMusic = \relative { a'4 b c b8( a) }
 altoMusic = \relative { e'4 e e f }
 tenorMusic = \relative { c'4 b e d8( c) }
 bassMusic = \relative { a4 gis a d, }
-allLyrics = \lyricmode {King of glo -- ry }
+allLyrics = \lyricmode { King of glo -- ry }
 <<
   \new Staff = "Soprano" \sopranoMusic
   \new Lyrics \allLyrics
@@ -2144,17 +2144,11 @@ allLyrics = \lyricmode {King of glo -- ry }
   \new Lyrics \allLyrics
   \new PianoStaff <<
     \new Staff = "RH" {
-      \set Staff.printPartCombineTexts = ##f
-      \partcombine
-      \sopranoMusic
-      \altoMusic
+      \partcombine \sopranoMusic \altoMusic
     }
     \new Staff = "LH" {
-      \set Staff.printPartCombineTexts = ##f
       \clef "bass"
-      \partcombine
-      \tenorMusic
-      \bassMusic
+      \partcombine \tenorMusic \bassMusic
     }
   >>
 >>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]