[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden)
From: |
Masamichi HOSODA |
Subject: |
Re: Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden) |
Date: |
Fri, 24 Apr 2015 20:59:11 +0900 (JST) |
> Patch counted down - please push
>
> https://codereview.appspot.com/227200043/
I don't have git account.
I've attached the patch file to this mail.
Would you push it?
>From e50938881680c6f673d6c66f1f9619d9b3abfc65 Mon Sep 17 00:00:00 2001
From: Masamichi Hosoda <address@hidden>
Date: Wed, 15 Apr 2015 21:51:46 +0900
Subject: [PATCH] Remove cygwin_conv_to_posix_path
cygwin_conv_to_posix_path is
deprecated on cygwin (32bit) and not available on cygwin64.
It is not needed in a pure cygwin environment.
---
flower/file-name.cc | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/flower/file-name.cc b/flower/file-name.cc
index eaadadf..c65d8fc 100644
--- a/flower/file-name.cc
+++ b/flower/file-name.cc
@@ -33,10 +33,6 @@ using namespace std;
#include <sys/stat.h>
#endif
-#ifdef __CYGWIN__
-#include <sys/cygwin.h>
-#endif
-
#ifndef ROOTSEP
#define ROOTSEP ':'
#endif
@@ -49,21 +45,6 @@ using namespace std;
#define EXTSEP '.'
#endif
-#ifdef __CYGWIN__
-static string
-dos_to_posix (const string &file_name)
-{
- char buf[PATH_MAX] = "";
- char s[PATH_MAX] = {0};
- file_name.copy (s, PATH_MAX - 1);
- /* ugh: char const* argument gets modified. */
- int fail = cygwin_conv_to_posix_path (s, buf);
- if (!fail)
- return buf;
- return file_name;
-}
-#endif /* __CYGWIN__ */
-
/** Use slash as directory separator. On Windows, they can pretty
much be exchanged. */
#if 0
@@ -144,12 +125,6 @@ File_name::to_string () const
File_name::File_name (string file_name)
{
-#ifdef __CYGWIN__
- /* All system functions would work, even if we do not convert to
- posix file_name, but we would think that \foe\bar\baz.ly is in
- the cwd. */
- file_name = dos_to_posix (file_name);
-#endif
#ifdef __MINGW32__
file_name = slashify (file_name);
#endif
--
2.1.4
- Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden), pkx166h, 2015/04/18
- Re: Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden), v . villenave, 2015/04/18
- Re: Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden), marco . atzeri, 2015/04/18
- Re: Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden), pkx166h, 2015/04/21
- Re: Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden), pkx166h, 2015/04/24
- Re: Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden),
Masamichi HOSODA <=
- Re: Remove cygwin_conv_to_posix_path (issue 227200043 by address@hidden), pkx166h, 2015/04/24