[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by
From: |
pkx166h |
Subject: |
Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden) |
Date: |
Fri, 03 Oct 2014 07:32:08 +0000 |
Thanks Valentine
----
https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely#newcode2654
Documentation/notation/input.itely:2654: LilyPond can produce files that
conform to the MIDI (Musical Instrument Digital Interface) standard and
so allow for the checking of the music
On 2014/10/02 11:19:12, Valentin Villenave wrote:
Source code formatting: some lines seem a bit long.
Done.
https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely#newcode2659
Documentation/notation/input.itely:2659: MIDI files do not contain sound
like an MP3 file but require additional
On 2014/10/02 11:19:12, Valentin Villenave wrote:
As a matter of consistency, I'd mention a patent-free format alongside
mp3 here.
Done.
https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely#newcode2689
Documentation/notation/input.itely:2689: only produce MIDI output files.
No notation will be printed.
On 2014/10/02 11:19:12, Valentin Villenave wrote:
I'd make this paragraph a @warning{}.
Done.
https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely#newcode2784
Documentation/notation/input.itely:2784: @q{Articulate} script.
On 2014/10/02 11:19:12, Valentin Villenave wrote:
Isn't capitalization redundant with @q{}?
Well it's called 'Articulate.ly' and the way it is bandied about in the
forums, the term 'Articulate script' seems (to me anyway) like a proper
noun. Hence the capitalization.
https://codereview.appspot.com/120480043/diff/140001/Documentation/notation/input.itely#newcode2888
Documentation/notation/input.itely:2888: Only @q{simple} articulations
are supported: staccato, staccatissimo,
On 2014/10/02 11:19:12, Valentin Villenave wrote:
Maybe quotes aren't justified here.
Done.
https://codereview.appspot.com/120480043/
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden), v . villenave, 2014/10/02
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden),
pkx166h <=
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden), dak, 2014/10/03
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden), pkx166h, 2014/10/03
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden), tdanielsmusic, 2014/10/03
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden), ht . lilypond . development, 2014/10/04
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden), pkx166h, 2014/10/20
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden), ht . lilypond . development, 2014/10/25
- Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden), tdanielsmusic, 2014/10/26