lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Remove warning when there are no noteheads to attach lyrics to. (issue 1


From: janek . lilypond
Subject: Remove warning when there are no noteheads to attach lyrics to. (issue 120200043 by address@hidden)
Date: Sun, 27 Jul 2014 10:24:29 +0000

Reviewers: ,

Message:
Pushed as

commit 476687b992c1c0d551b0d425e5ece78c39cfc3ef
Author: Janek WarchoĊ‚ <address@hidden>
Date:   Sat Jul 26 09:00:39 2014 +0200

    Remove warning when there are no noteheads to attach lyrics to.

    The warning was added to address issue 248, but it is now moot after
    issue 3254 (c73b41b3e7be6d7): attaching lyrics to a note-less
context
    (like Devnull) is perfectly legal now.


Description:
Remove warning when there are no noteheads to attach lyrics to.

The warning was added to address issue 248, but it is now moot after
issue 3254 (c73b41b3e7be6d7): attaching lyrics to a note-less context
(like Devnull) is perfectly legal now.

Please review this at https://codereview.appspot.com/120200043/

Affected files (+0, -4 lines):
  M lily/lyric-engraver.cc


Index: lily/lyric-engraver.cc
diff --git a/lily/lyric-engraver.cc b/lily/lyric-engraver.cc
index 1cbaffeb7d5376f7301cbdbcefc2301c28503d23..bbe15845a61a77379c070b6839637d69c4c1a507 100644
--- a/lily/lyric-engraver.cc
+++ b/lily/lyric-engraver.cc
@@ -174,24 +174,20 @@ Lyric_engraver::stop_translation_timestep ()
           Grob *head = get_current_note_head (voice, include_grace_notes);

           if (head)
             {
               text_->set_parent (head->get_parent(X_AXIS), X_AXIS);
               if (melisma_busy (voice)
                   && !to_boolean (get_property ("ignoreMelismata")))
                 text_->set_property ("self-alignment-X",
get_property ("lyricMelismaAlignment"));
             }
-          else
- text_->warning (_ ("Aligning lyric syllables to notes was requested," - " but there are no notes in the specified context." - " Syllable will be attached to a PaperColumn instead."));
         }

       last_text_ = text_;
       text_ = 0;
     }
   event_ = 0;
 }

 ADD_TRANSLATOR (Lyric_engraver,
                 /* doc */



reply via email to

[Prev in Thread] Current Thread [Next in Thread]