lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CG: Update of Patchy instructions (issue 112280043 by address@hidden


From: julien . rioux
Subject: Re: CG: Update of Patchy instructions (issue 112280043 by address@hidden)
Date: Mon, 21 Jul 2014 18:30:31 +0000

Thanks for this! Some comments.
Cheers,
Julien


https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi
File Documentation/contributor/administration.itexi (right):

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode161
Documentation/contributor/administration.itexi:161: knowledge of of
compiling LilyPond and its documentation along with
"of of"

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode172
Documentation/contributor/administration.itexi:172: requires some human
intervention in order to to visually check for any
"to to"

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode178
Documentation/contributor/administration.itexi:178: compile, including
building all the LilyPond documentation, finally
The script makes sure that the new HEAD compiles, it does not attempt to
compile every individual commit.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode238
Documentation/contributor/administration.itexi:238: Commit access
@emph{is} required to test patches, but a valid login
"to test patches" -> "to test and push new commits"

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode256
Documentation/contributor/administration.itexi:256: of the
@file{patches/} directory to your @var{PATH}.
Would be useful to give the exact command line to clone the repo.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode430
Documentation/contributor/administration.itexi:430: The script can also
be run using a @emph{single} tracker issue number as
You can have multiple arguments, each an issue number.

https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi#newcode525
Documentation/contributor/administration.itexi:525: @unnumberedsubsubsec
Checking the regression test results
OK, I made it this far.

https://codereview.appspot.com/112280043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]