Re: \retrograde fails on slurs (issue 110540043 by address@hidden)

[dak]

Reviewers: lemzwerg,

Message:
On 2014/07/13 15:27:37, lemzwerg wrote:
> LGTM.


https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm
> File scm/modal-transforms.scm (right):


https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm#newcode134
> scm/modal-transforms.scm:134: \n(see).
> @code{transposer-factory}

Instead of the (see)?  Yeah, looks pretty nonsensical on second thought.
 I just wanted a different line wrap in order to keep Emacs from
considering everything after (see ... as a function, but it seems
uncalled for anyway.

Description:
\retrograde fails on slurs

The section "Retrograde" in the Notation Reference is affected.
This became likely exposed with issue 2240; the corresponding
regtest does not cover it.  The problem was existent previously
for slurs and other spans inside of chords.


Also contains commit:

Add slur to modal-transform regtest motif

Please review this at https://codereview.appspot.com/110540043/

Affected files (+7, -4 lines):
  M input/regression/modal-transforms.ly
  M scm/modal-transforms.scm


Index: input/regression/modal-transforms.ly
diff --git a/input/regression/modal-transforms.ly  
b/input/regression/modal-transforms.ly
index  
d514a92a09bcf727e3d527143cc6e3590fa9940d..9ff66c157b4c87944671faab8dba95f1b75a9257  
100644
--- a/input/regression/modal-transforms.ly
+++ b/input/regression/modal-transforms.ly
@@ -9,8 +9,8 @@ cOctatonicScale = {
   ges' aes' a' b'
 }
 motif = {
-  c'8. ees'16 ges'8. a'16
-  b'8. aes'16 f'8. d'16
+  c'8. ees'16( ges'8. a'16
+  b'8.) aes'16 f'8. d'16
 }

 \score {
Index: scm/modal-transforms.scm
diff --git a/scm/modal-transforms.scm b/scm/modal-transforms.scm
index  
3e31f660e4e7e10fdd3a6a40cf14f3dce7d0b3a8..cbd2042fa0049ebbacb8d6273ee9b14a3c9aa8e8  
100644
--- a/scm/modal-transforms.scm
+++ b/scm/modal-transforms.scm
@@ -130,8 +130,8 @@ LilyPond scheme pitches, e.g. @code{(ly:make-pitch 0 2  
0)}
   "Recurse through @var{music}, extracting pitches.
 Returns a list of pitch objects, e.g
 @code{'((ly:make-pitch 0 2 0) (ly:make-pitch 0 4 0) ... )}
-Typically used to construct a scale for input to transposer-factory
-(see).
+Typically used to construct a scale for input to transposer-factory\
+\n(see).
 "

   (let ((elements (ly:music-property music 'elements))
@@ -192,12 +192,15 @@ Typically used to construct a scale for input to  
transposer-factory
   ;; inversion and retrograding.

   (let* ((elements (ly:music-property music 'elements))
+         (arts (ly:music-property music 'articulations))
          (reversed (reverse elements))
          (element (ly:music-property music 'element))
          (span-dir (ly:music-property music 'span-direction)))

     (ly:music-set-property! music 'elements reversed)

+    (for-each retrograde-music arts)
+
     (if (ly:music? element)
         (ly:music-set-property!
          music 'element