Re: Fix infinite loop in Completion_heads_engraver at invalid measure position (issue 3888). (issue 81220043)

[lemzwerg]

Thanks for working on this!


https://codereview.appspot.com/81220043/diff/20001/input/regression/time-signature-midmeasure.ly
File input/regression/time-signature-midmeasure.ly (right):

https://codereview.appspot.com/81220043/diff/20001/input/regression/time-signature-midmeasure.ly#newcode5
input/regression/time-signature-midmeasure.ly:5: except in an anacrusis
or when ignoreBarChecks is true.
@code{ignoreBarChecks}

https://codereview.appspot.com/81220043/diff/20001/input/regression/time-signature-midmeasure.ly#newcode6
input/regression/time-signature-midmeasure.ly:6: measurePosition is
reset to 0, so a full measure follows, regardless
@code{measurePosition}

https://codereview.appspot.com/81220043/diff/20001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):

https://codereview.appspot.com/81220043/diff/20001/lily/completion-note-heads-engraver.cc#newcode122
lily/completion-note-heads-engraver.cc:122: programming_error ("invalid
measure position: " + e->to_string () + " of " + l->to_string ());
In general, it would be favourable to use a maximum line length of 80
characters, but it feels like tilting at windmills :-)

https://codereview.appspot.com/81220043/diff/20001/scm/define-music-callbacks.scm
File scm/define-music-callbacks.scm (right):

https://codereview.appspot.com/81220043/diff/20001/scm/define-music-callbacks.scm#newcode113
scm/define-music-callbacks.scm:113: (ly:music-warning music "\\time in
mid-measure at ~A"
Please make this translatable.

https://codereview.appspot.com/81220043/