[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Parse composite music in context modifications in \notemode (issue 1
From: |
Janek Warchoł |
Subject: |
Re: Parse composite music in context modifications in \notemode (issue 12773047) |
Date: |
Tue, 27 Aug 2013 11:10:00 +0200 |
I like this! Please put this example into commit message and/or a
comment in the code :)
best,
Janek
2013/8/27 <address@hidden>:
> Reviewers: janek,
>
> Message:
>
> On 2013/08/27 07:43:41, janek wrote:
>>
>> Hi,
>
>
>> could you write a 2-sentence explanation why we want to do this?
>
>
>> Janek
>
>
> \new Staff \with { \transposition f' } { g a b c' }
>
>
> Description:
> Parse composite music in context modifications in \notemode
>
> Please review this at https://codereview.appspot.com/12773047/
>
> Affected files:
> M lily/parser.yy
>
>
> Index: lily/parser.yy
> diff --git a/lily/parser.yy b/lily/parser.yy
> index
> 53bddf5eaf64dcf48824e05740d20d330919faab..f09e092dab0acddc4f6d5166a8164d36dd1d09a3
> 100644
> --- a/lily/parser.yy
> +++ b/lily/parser.yy
> @@ -627,7 +627,16 @@ context_def_spec_block:
>
> context_mod_arg:
> embedded_scm
> - | composite_music
> + |
> + {
> + SCM nn = parser->lexer_->lookup_identifier ("pitchnames");
> + parser->lexer_->push_note_state (nn);
> + }
> + composite_music
> + {
> + parser->lexer_->pop_state ();
> + $$ = $2;
> + }
> ;
>
> context_mod_embedded:
>
>