[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uses single algorithm for side-position spacing. (issue 6827072)
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Uses single algorithm for side-position spacing. (issue 6827072) |
|
Date: |
Thu, 22 Aug 2013 06:27:46 +0000 |
On 2012/12/22 16:11:10, mike7 wrote:
On 22 déc. 2012, at 07:43, mailto:address@hidden wrote:
https://codereview.appspot.com/6827072/diff/34001/lily/axis-group-interface.cc#newcode62
> lily/axis-group-interface.cc:62: return SCM_BOOL_T;
> Now the whole note-column is marked cross-staff if its stem spans
> staves. Check if Note_column::cross_staff_extent() still makes
sense
It does, because this function is a replacement for Grob::extent for
NoteColumns. Axis_group_interface::height, even in unpure, won't take
cross-staff stems into account.
The function Axis_group_interface::height() does not seem to skip
cross-staff grobs; it calls functions that eventually try to set stem
directions, including those for cross-staff stems.
https://codereview.appspot.com/6827072/