Re: metronome/tempo marks: accurate initial placment, for page breaking (issue 9073043)

[k-ohara5a5a]

Reviewers: lemzwerg,


https://codereview.appspot.com/9073043/diff/1/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/9073043/diff/1/scm/output-lib.scm#newcode861
scm/output-lib.scm:861: (ly:grob-property grob 'outside-staff-padding
0.0))
On 2013/05/01 09:32:51, lemzwerg wrote:
> It would be interesting to know why 1.0 was added previously...

I forgot.  Oh yeah, to clear the vertical-skyline-padding of
NoteColumns.

The metronome and tempo marks, when engraved at the Score level have an
initial placement just above 0.0, while the uppermost staff has its
uppermost extent at 0.0 and all further staves below that, during the
note-spacing step.  That would give tempo and rehearsal marks a natural
way to space against each other independently of the staff-contents,
except that note-column padding outside of extents goes above 0.0.

Description:
metronome/tempo marks: accurate initial placment, for page breaking

Please review this at https://codereview.appspot.com/9073043/

Affected files:
  M scm/output-lib.scm


Index: scm/output-lib.scm
diff --git a/scm/output-lib.scm b/scm/output-lib.scm
index  
caa7032c70b9a5879f3a4adb05f899d1b3196b9a..1cde36c8710418b289a9c0efb4aba04633d7a80b  
100644
--- a/scm/output-lib.scm
+++ b/scm/output-lib.scm
@@ -859,7 +859,7 @@ and duration-log @var{log}."
    rehearsal marks, for use in note-spacing."
    (* (+ (ly:staff-symbol-staff-radius grob)
          (ly:grob-property grob 'outside-staff-padding 0.0)
-         1.0)
+         0.3) ; clear any skyline-vertical-padding of noteColumn
       (ly:grob-property grob 'direction CENTER)))

 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;