lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Rewrites last-grob-cause function (issue 7092058)


From: address@hidden
Subject: Re: Rewrites last-grob-cause function (issue 7092058)
Date: Wed, 16 Jan 2013 13:12:24 +0100

On 16 janv. 2013, at 11:11, address@hidden wrote:

> 
> https://codereview.appspot.com/7092058/diff/1/scm/output-lib.scm
> File scm/output-lib.scm (right):
> 
> https://codereview.appspot.com/7092058/diff/1/scm/output-lib.scm#newcode57
> scm/output-lib.scm:57: (define-public (last-grob-cause grob)
> The name is quite clearer, and the semantics make sense.  It is
> conceivable that it would be more useful to return #f instead of the
> grob itself when there is no preceding grob cause.  But I am not really
> sure about that, and this variant _is_ consistent as well.  However, I
> should be surprised if previous callers won't need to be notified of the
> renaming as well.  This has been committed so recently that, in spite of
> this being a public function, a convert-ly rule seems like overkill to
> me (it would basically cover one version or less).  But the callers
> introduced with the same commit will need renaming, anyway.
> 
> https://codereview.appspot.com/7092058/

Ah, this is cruft.  Just did a git grep and didn't find it used anywhere.  This 
must have been left-over from an old patch set.
I'll just post a patch deleting it.

Cheers,
MS




reply via email to

[Prev in Thread] Current Thread [Next in Thread]