[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uses single algorithm for side-position spacing. (issue 6827072)
From: |
dak |
Subject: |
Re: Uses single algorithm for side-position spacing. (issue 6827072) |
Date: |
Tue, 15 Jan 2013 09:58:17 +0000 |
https://codereview.appspot.com/6827072/diff/38003/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/6827072/diff/38003/scm/output-lib.scm#newcode54
scm/output-lib.scm:54: (define-public (non-event-cause grob)
Mike, this function is total crap. What is it supposed to do? Events
are _never_ caused by grobs, so the first branch in the cond is
nonsense. This is essentially
(let ((cause (ly:grob-property grob 'cause)))
(and (ly:grob? cause) cause))
and nothing else. What you presumably meant (but it is hard to guess,
given that you fail to document anything) is
(and (ly:grob? cause) (or (non-event-cause cause) cause))
namely the last grob cause in a row, if any. Of course,
non-event-cause for that function would then be quite silly,
and last-grob-cause more appropriate.
Can you _please_ make this do anything useful _and_ document what it is
supposed to do?
https://codereview.appspot.com/6827072/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Uses single algorithm for side-position spacing. (issue 6827072),
dak <=