[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds support for cross-staff-stems (issue 6344092)
From: |
Phil Holmes |
Subject: |
Re: Adds support for cross-staff-stems (issue 6344092) |
Date: |
Fri, 31 Aug 2012 09:46:10 +0100 |
----- Original Message -----
From: <address@hidden>
To: <address@hidden>; <address@hidden>;
<address@hidden>; <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Friday, August 31, 2012 12:12 AM
Subject: Re: Adds support for cross-staff-stems (issue 6344092)
http://codereview.appspot.com/6344092/diff/12002/scm/music-functions.scm
File scm/music-functions.scm (right):
http://codereview.appspot.com/6344092/diff/12002/scm/music-functions.scm#newcode1784
scm/music-functions.scm:1784: (if (<= 2 (length stems))
Why not use "and" here and leave out the #f below? Then one does not
hunt for #f to figure out what happens when the condition is false.
http://codereview.appspot.com/6344092/diff/12002/scm/music-functions.scm#newcode1801
scm/music-functions.scm:1801: (let ((span (ly:engraver-make-grob trans
'Stem '())))
Why not have "root" as the cause, the last element of
ly:engraver-make-grob? That would make the stem span tweakable.
http://codereview.appspot.com/6344092/
This patch has been approved, pushed and the Rietveld closed. If you want
to propose changes, it should be a new patch.
--
Phil Holmes