[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Autobeaming works properly with tuplet recheck (Issue 2408) (issue 5
From: |
dak |
Subject: |
Re: Autobeaming works properly with tuplet recheck (Issue 2408) (issue 5844052) |
Date: |
Wed, 21 Mar 2012 11:00:30 +0000 |
http://codereview.appspot.com/5844052/diff/3001/lily/beaming-pattern.cc
File lily/beaming-pattern.cc (right):
http://codereview.appspot.com/5844052/diff/3001/lily/beaming-pattern.cc#newcode361
lily/beaming-pattern.cc:361: }
On 2012/03/21 10:51:29, MikeSol wrote:
My comment has nothing to do with your patch but with this function -
it seems
like there's a memory leak with *dur (I know very little about memory
management, so sorry in advance if I'm totally off...).
No, you are quite correct. There is no sense in allocating a duration
on the heap here. It would be simpler to just write
Duration dur (2 + ...); [...] * dur.get_length ();
http://codereview.appspot.com/5844052/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Autobeaming works properly with tuplet recheck (Issue 2408) (issue 5844052),
dak <=