[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Axis group interface ignores column rank for pure-from-neighbor-inte
From: |
k-ohara5a5a |
Subject: |
Re: Axis group interface ignores column rank for pure-from-neighbor-interface (issue 5843063) |
Date: |
Tue, 20 Mar 2012 02:36:07 +0000 |
http://codereview.appspot.com/5843063/diff/5001/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
http://codereview.appspot.com/5843063/diff/5001/lily/axis-group-interface.cc#newcode330
lily/axis-group-interface.cc:330: ||
Pure_from_neighbor_interface::has_interface (me))
Now that the engraver is working correctly, do you still need this
change ?
I think the test against 'start' and 'end' was there to better estimate
the height of just what is on the currently-considered line. If you
bypass this test, then sometimes the page breaking will be fooled :
\paper {#(set-paper-size "a6" 'landscape) }
\new PianoStaff <<
\new Staff \relative f'' {
c4 c c g a a g2 | e'4 e d2 | c2 r2
c4 c c g a a g2 | e'4 e d2 | c2 r2
}
\addlyrics {
Old Mac Don -- ald had a farm, in O -- hi -- o. \set stanza = "1."
On that farm he had some cows, in O -- hi -- o. }
\addlyrics {
\repeat unfold 11 \skip1 \set stanza = "2."
On that farm he had some pigs, in O -- hi -- o. }
\addlyrics {
\repeat unfold 11 \skip1 \set stanza = "3."
On that farm he had some dogs, in O -- hi -- o. }
\addlyrics {
\repeat unfold 11 \skip1 \set stanza = "4."
On that farm he had some ducks, in O -- hi -- o. }
\addlyrics {
\repeat unfold 11 \skip1 \set stanza = "5."
On that farm he had some sheep, in O -- hi -- o. }
\new Staff {
\clef bass
c1 f2 c2 c2 g2 c1
c1 f2 c2 c2 g2 c1
}
>>
We should stop lyrics from breaking through span bars at the stage where
horizontal spacing constraints are determined, when we should have
start=0 and end=INT_MAX because the whole score is conceptually one long
line at that point.
http://codereview.appspot.com/5843063/