Re: Add some polyphonically directed grobs (issue4387046)

[Colin Campbell]

On 11-04-09 07:57 PM, address@hidden wrote:
> Reviewers: ,
>
> Message:
> Small patch that takes new grobs in account :
> Accidental suggestions, dynamics, ligatures and spanned trills.
>
> Regards,
> Bertrand
>
> Description:
> Add some polyphonically directed grobs
>
> Accidental suggestions, dynamics, ligatures and spanned trills added to
> direction-polyphonic-grobs.
>
> Please review this at http://codereview.appspot.com/4387046/
>
> Affected files:
>   M scm/music-functions.scm
>
>
> Index: scm/music-functions.scm
> diff --git a/scm/music-functions.scm b/scm/music-functions.scm
> index 
> 9790cbf1a3d145a8524b3e20b1b874c59c117de6..6192cbd4863e69c21ced4fc1bf99ae2ac6fa4daf 
> 100644
> --- a/scm/music-functions.scm
> +++ b/scm/music-functions.scm
> @@ -400,10 +400,14 @@ in @var{grob}."
>            'grob-property gprop))
>
>  (define direction-polyphonic-grobs
> -  '(DotColumn
> +  '(AccidentalSuggestion
> +    DotColumn
>      Dots
> +    DynamicLineSpanner
> +    DynamicText
>      Fingering
>      LaissezVibrerTie
> +    LigatureBracket
>      PhrasingSlur
>      RepeatTie
>      Rest
> @@ -411,7 +415,8 @@ in @var{grob}."
>      Slur
>      Stem
>      TextScript
> -    Tie))
> +    Tie
> +    TrillSpanner))
>
>  (define-safe-public (make-voice-props-set n)
>    (make-sequential-music

I've added issue 1603, Bertrand, just to track the patch.  It compiled 
cleanly on my machine, although it showed a noticeable shift downward of 
the fallback staff in regression/out-test/quote-cue-event-types.ly as 
well as moving the ff dynamic above the staff.

HTH,
Colin Campbell
Bug Squad

--
The test of our progress is not whether we add more to the abundance
of those who have much, it is whether we provide enough for those who
have too little.
-Franklin D. Roosevelt, 32nd US President (1882-1945)