[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allows users to request that beam collision occur on the Voice level
From: |
n . puttock |
Subject: |
Re: Allows users to request that beam collision occur on the Voice level. (issue4367042) |
Date: |
Fri, 08 Apr 2011 19:19:17 +0000 |
http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly
File input/regression/beam-collision-voice-only.ly (right):
http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode1
input/regression/beam-collision-voice-only.ly:1: \version "2.13.58"
2.13.59
http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode9
input/regression/beam-collision-voice-only.ly:9: << { c8 [s c ] } \\ {
s8 c' s8 } >>
c8[ s c]
http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode10
input/regression/beam-collision-voice-only.ly:10: c, [des' ]
c,[ des']
http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode12
input/regression/beam-collision-voice-only.ly:12: << { c,8 [s c ] } \\ {
s8 c' s8 } >>
c,8[ s c]
http://codereview.appspot.com/4367042/diff/1/input/regression/beam-collision-voice-only.ly#newcode13
input/regression/beam-collision-voice-only.ly:13: c, [des'! ]
c,[ des'!]
http://codereview.appspot.com/4367042/diff/1/lily/beam-collision-engraver.cc
File lily/beam-collision-engraver.cc (right):
http://codereview.appspot.com/4367042/diff/1/lily/beam-collision-engraver.cc#newcode52
lily/beam-collision-engraver.cc:52: Beam_collision_engraver::less
(Grob_info i, Grob_info j)
This name implies a comparison between engravers. It would make more
sense defining Grob_info::less ().
http://codereview.appspot.com/4367042/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):
http://codereview.appspot.com/4367042/diff/1/scm/define-grobs.scm#newcode358
scm/define-grobs.scm:358: (collision-voice-only . #f)
remove
http://codereview.appspot.com/4367042/