lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add the Instrument_name_engraver also to all group contexts (issue40


From: n . puttock
Subject: Re: Add the Instrument_name_engraver also to all group contexts (issue4031043)
Date: Thu, 27 Jan 2011 22:19:51 +0000


http://codereview.appspot.com/4031043/diff/7001/Documentation/notation/staff.itely
File Documentation/notation/staff.itely (right):

http://codereview.appspot.com/4031043/diff/7001/Documentation/notation/staff.itely#newcode939
Documentation/notation/staff.itely:939: @code{ChordNames},
@code{Fretboards}, or @code{FiguredBass}),
Already added to FretBoards.

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly
File input/regression/instrument-name-groups.ly (right):

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly#newcode2
input/regression/instrument-name-groups.ly:2: \header{
\header {

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly#newcode17
input/regression/instrument-name-groups.ly:17: \new StaffGroup \with {
instrumentName = "StaffGroup" } <<
#"StaffGroup"

etc.

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly#newcode24
input/regression/instrument-name-groups.ly:24: \new Staff { c''4 }
trailing whitespace

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly#newcode25
input/regression/instrument-name-groups.ly:25: \new Staff { c''4 }
trailing whitespace

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly#newcode26
input/regression/instrument-name-groups.ly:26: \new Staff { c''4 }
trailing whitespace

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly#newcode32
input/regression/instrument-name-groups.ly:32: % TODO: Nested groups
inherit the instrument name from the parent group,
set instrumentName/shortInstrumentName in engraver-init.ly

(see entry for Staff)

http://codereview.appspot.com/4031043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]