lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] removed unused macro "classname" , unused funcion "demangle_


From: Graham Percival
Subject: Re: [PATCH] removed unused macro "classname" , unused funcion "demangle_classname", unneccessary file "flower/rtti.cc"
Date: Thu, 27 Jan 2011 13:33:14 +0000

On 1/26/11, Bernard Hurley <address@hidden> wrote:
> The definition of the function "demangle_classname" is the only content
> of flower/rtti.cc. This is only referenced in
> flower/include/virtual-methods.hh, where it is used in the definition of
> the macro "classname".
>
> Hence the references to "demangle_classname" in virtual-methods.hh can
> be deleted along with the file rtti.c
>
> Of course it is possible that someone may have added them recently with
> a view to using them for something, but it looks like historical cruft
> to me.

A quick check with both gitk flower/  and the online git browser shows
that they are, indeed, "historical cruft".  Your patch shows nothing
weird with a regtest comparison.

I'm building all the docs from scratch right now, and I'll push it
once the build finishes and if stuff looks fine.  Thanks!

Cheers,
- Graham



reply via email to

[Prev in Thread] Current Thread [Next in Thread]