Re: Implement compound time signatures (issue3992042)

[n . puttock]

http://codereview.appspot.com/3992042/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/3992042/diff/1/Documentation/changes.tely#newcode77
Documentation/changes.tely:77: c c c c c c c
c8

http://codereview.appspot.com/3992042/diff/1/Documentation/changes.tely#newcode79
Documentation/changes.tely:79: c c c c c c c4 c8 c c
c8

http://codereview.appspot.com/3992042/diff/1/input/regression/compound-time-signatures.ly
File input/regression/compound-time-signatures.ly (right):

http://codereview.appspot.com/3992042/diff/1/input/regression/compound-time-signatures.ly#newcode20
input/regression/compound-time-signatures.ly:20: \repeat unfold 10 c8
\repeat unfold 20 c16\break
c16 \break

etc.

http://codereview.appspot.com/3992042/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/3992042/diff/1/ly/music-functions-init.ly#newcode219
ly/music-functions-init.ly:219: "Create compound time signatures. The
argument is a Scheme list of "
indent

(_i "one long docstring")

splitting the description up into separate strings means they're all
discarded apart from the first one:

#(display
  (procedure-documentation
   (ly:music-function-extract compoundMeter)))

-> Create compound time signatures. The argument is a Scheme list of

http://codereview.appspot.com/3992042/diff/1/ly/music-functions-init.ly#newcode234
ly/music-functions-init.ly:234: \once \override Staff.TimeSignature
#'stencil = #ly:text-interface::print
#(lambda (grob)
   (grob-interpret-markup grob (format-compound-time $args)))

http://codereview.appspot.com/3992042/diff/1/ly/music-functions-init.ly#newcode235
ly/music-functions-init.ly:235: \once \override Staff.TimeSignature
#'text = #(format-compound-time $args)
remove

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm
File scm/time-signature-settings.scm (right):

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode309
scm/time-signature-settings.scm:309:
;%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
;;;

etc.

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode313
scm/time-signature-settings.scm:313: (let* ((ll (reverse l)))
let

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode317
scm/time-signature-settings.scm:317: (join-markups (cons (car remaining)
(cons m markups)) (cdr remaining))
indent

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode320
scm/time-signature-settings.scm:320: ; Use a centered-column inside a
left-column, because the centered column
;;

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode321
scm/time-signature-settings.scm:321: ; moves its reference point to the
center, which the left-column undoes.
;;

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode334
scm/time-signature-settings.scm:334: (let* ((sigs (map
format-time-fraction time-sig)))
let

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode357
scm/time-signature-settings.scm:357: (let* ((sigs (map
calculate-time-fraction time-sig)))
let

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode361
scm/time-signature-settings.scm:361: (add-moment (ly:moment-add moment
(car remaining)) (cdr remaining))
indent

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode379
scm/time-signature-settings.scm:379: ((not (pair? time-sig)) 4)
indent

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#newcode393
scm/time-signature-settings.scm:393: ; Normalize to given beat, extract
the beats and join them to one list
;;

http://codereview.appspot.com/3992042/