lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Coding style


From: David Kastrup
Subject: Re: Coding style
Date: Fri, 14 Jan 2011 10:03:20 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Jan Nieuwenhuizen <address@hidden> writes:

>> In this particular case it may not matter, but the
>> 
>>   while ((flip(&d) != UP)
>> 
>> is a common idiom in the lilypond source code
>
> Chiming in on that; I think that we prefer these
> patterns or idioms over specialisations.

In this particular case, it declares a loop variable, some variables
inside and various other stuff, in order to save one call.

And I have the suspicion that sorting one group reversely might solve
the bug we are seeing here, anyway...

> Also, if you find a nice way of making the idiom nicer,
> change it all over the source tree in one go.

Well, I showed one example using break.

-- 
David Kastrup




reply via email to

[Prev in Thread] Current Thread [Next in Thread]