Re: Correct convert-ly of page spacing (issue3793046)

[k-ohara5a5a]

Patch set relative to current head,
and one typo fixed in an output message.
Email patch to follow shortly to Graham.

Carl wrote> ... git-cl upload master
Thanks, Carl.
I committed locally first, so relative to my local this gave an empty
diff.  git-cl upload origin/master

So I see that Rietveld compares against the appropriate base for each
patch set.  Very nice.


http://codereview.appspot.com/3793046/diff/6001/python/convertrules.py
File python/convertrules.py (right):

http://codereview.appspot.com/3793046/diff/6001/python/convertrules.py#newcode2970
python/convertrules.py:2970: r"  top-system-spacing #'space = #(/
obsolete-\1 staff-space)",
On 2011/01/08 22:32:46, Neil Puttock wrote:
> newlines looks a bit tidier here

But %-commented-out page-spacing variables
 %  oldvar = 3\in
seem particularly common (on mutopia).  In such cases my assignment to
newvar on the next line would give an error.  When I tested that method
and looked at the error, I decided it might confuse reasonable users.

http://codereview.appspot.com/3793046/