Re: Change stringTunings entries from semitones to pitches (issue3842041)

[Carl . D . Sorensen]

I've responded to all the commandments and put up a new patch.

Thanks for all of your input.

Please review.

Carl



http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely#newcode524
Documentation/notation/fretted-strings.itely:524: chord construct must
be in absolute note mode, and the string
On 2010/12/29 09:13:24, pkx166h wrote:
> Hello, referred to 'Absolute octave entry' in the NR, not 'Absoulte
note mode'.

The heading is "Absolute octave entry".  The mode is "absolute octave
mode" or "absolute mode" -- see "Relative octave entry".

I've changed to "absolute octave mode".

> Could we also have an @ref{} here too please (and thus an addition to
the
> @seealso).

Done.

http://codereview.appspot.com/3842041/diff/6001/ly/string-tunings-init.ly
File ly/string-tunings-init.ly (right):

http://codereview.appspot.com/3842041/diff/6001/ly/string-tunings-init.ly#newcode43
ly/string-tunings-init.ly:43: (make-music 'SequentialMusic 'void #t)))
I've added a new music function contextStringTunings (the name is
negotiable) that does the property set as well.

It sets stringTunings for both TabStaff and FretBoards.

I don't want to call it setStringTuning because it will be confused with
\set stringTunings.

http://codereview.appspot.com/3842041/