|
From: | Marc Hohl |
Subject: | Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042) |
Date: | Thu, 16 Sep 2010 14:15:40 +0200 |
User-agent: | Thunderbird 2.0.0.24 (X11/20100317) |
address@hidden schrieb:
Looks good to me. Just a comment on the name of the new property to be added to details. Thanks, Carl
Hello Carl,
http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right):http://codereview.appspot.com/2191042/diff/1/scm/define-grobs.scm#newcode1979scm/define-grobs.scm:1979: (tied-to . #f))) tied-from might be a better name than tied-to, since it's the property of the left-hand note that we're adjusting, rather than the property of the right hand note.
Just for clarification, since I am not a native speaker: Consider c'4 ~ c'4 ( d'2 ).I used "tied-to", because this value is set while evaluating the tie, so from this point of view, the right note (i.e. the second c') is tied to the left c'. This information is then passed to the slur/glissando routine. Am I wrong here? Is "tied-to" misleading?
AFAIK, the only situation in which this may occur is when a tie is followed by a spanner like slur, glissando, or bend. When a tie follows another spanner, lilypond already worksAnd maybe something like span-start or spanner-start would be even better, since I'd guess we want the same behavior to apply for slurs, glissandos, and bends, all of which are spanners. And starting the spanner at the note-head means we want to display the number.
as expected.But I thought about alternatives like "tie-terminate" or "terminate-tie" or "tie-end" before,
but "tied-to" felt just right. Marc http://codereview.appspot.com/2191042/
[Prev in Thread] | Current Thread | [Next in Thread] |