[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #
From: |
David Kastrup |
Subject: |
Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords |
Date: |
Tue, 24 Nov 2009 06:46:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
Joe Neeman <address@hidden> writes:
> On Tue, 2009-11-24 at 01:03 +0100, David Kastrup wrote:
>> Carl Sorensen <address@hidden> writes:
>> > IIUC, our policy is that *every* patch that is applied should result
>> > in a buildable LilyPond. If not, it's a bad patch.
>>
>> I don't consider this policy prudent in the particular situation "API
>> change implemented with little code" "Wagonloads of changes in API
>> users" because everything within part 1 requires an intensive review,
>> while the much larger part 2 can be skimmed at a much faster pace.
>
> On the other hand, patches which break lilypond make git-bisect much
> less fun.
Uh yes. Good point. You got me there.
It appears that the Cc functionality for git-cl was not working, so just
for the record: <URL:http://codereview.appspot.com/160048>.
--
David Kastrup
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, (continued)
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Kieren MacMillan, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Werner LEMBERG, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Han-Wen Nienhuys, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Carl Sorensen, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Joe Neeman, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords,
David Kastrup <=
Re: [PATCH 2/4] scm/harp-pedals.scm: Fold make-harp-pedal into \harp-pedal markup., Reinhold Kainhofer, 2009/11/23
Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups, Han-Wen Nienhuys, 2009/11/22
Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups, Reinhold Kainhofer, 2009/11/23