[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tracker 836: Add facility to change output file-name for a \book blo
From: |
ian |
Subject: |
Re: Tracker 836: Add facility to change output file-name for a \book block |
Date: |
Thu, 12 Nov 2009 21:42:17 +0000 |
music-functions-init.ly
spaces+tab lines sorted.
indentation ll 626-633 fixed.
Is the patch ready to push now?
Cheers,
Ian
http://codereview.appspot.com/150044/diff/11/1015
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/150044/diff/11/1015#newcode611
ly/music-functions-init.ly:611: (filter
On 2009/11/12 01:12:36, Carl wrote:
Tab following space -- we never want to have that. Start the line
with as many
tabs as desired, followed by spaces if necessary to create the proper
indentation. Or use all spaces -- that's fine too. But not space tab
space.
Done.
http://codereview.appspot.com/150044/diff/11/1015#newcode612
ly/music-functions-init.ly:612: (lambda (m) (eq? 'NoteEvent
(ly:music-property m 'name)))
On 2009/11/12 01:12:36, Carl wrote:
Tab following space
Done.
http://codereview.appspot.com/150044/diff/11/1015#newcode613
ly/music-functions-init.ly:613: (ly:music-property ev-chord
'elements))))
On 2009/11/12 01:12:36, Carl wrote:
Tab following space
Done.
http://codereview.appspot.com/150044/diff/11/1015#newcode626
ly/music-functions-init.ly:626: (begin
On 2009/11/12 01:12:36, Carl wrote:
After changing for-each, you'll need to change (begin to match.
Done.
http://codereview.appspot.com/150044/diff/11/1015#newcode633
ly/music-functions-init.ly:633: trill-events)))))
On 2009/11/12 01:12:36, Carl wrote:
Tab following spaces
Done.
http://codereview.appspot.com/150044
- Re: Tracker 836: Add facility to change output file-name for a \book block, (continued)
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/08
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/08
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/09
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/11
- Re: Tracker 836: Add facility to change output file-name for a \book block, Carl . D . Sorensen, 2009/11/11
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/12
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/12
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/12
- Re: Tracker 836: Add facility to change output file-name for a \book block,
ian <=