[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tracker 836: Add facility to change output file-name for a \book blo
From: |
ian |
Subject: |
Re: Tracker 836: Add facility to change output file-name for a \book block |
Date: |
Wed, 04 Nov 2009 19:57:27 +0000 |
lily-library.scm changes after Patrick's feedback.
http://codereview.appspot.com/143055/diff/19/1020
File scm/lily-library.scm (right):
http://codereview.appspot.com/143055/diff/19/1020#newcode142
Line 142: (if (not book-filename)
On 2009/11/04 01:06:34, Patrick McCarty wrote:
The if block should be indented two more spaces here.
Done.
http://codereview.appspot.com/143055/diff/19/1020#newcode143
Line 143: (ly:parser-output-name parser)
On 2009/11/04 01:06:34, Patrick McCarty wrote:
These two lines should begin in the same column as (not ...)
Done.
http://codereview.appspot.com/143055/diff/19/1020#newcode149
Line 149: (let ((book-output-suffix (ly:parser-lookup parser
'book-output-suffix)))
On 2009/11/04 01:06:34, Patrick McCarty wrote:
indent the if block
Done.
http://codereview.appspot.com/143055
- Re: Tracker 836: Add facility to change output file-name for a \book block, pnorcks, 2009/11/03
- Re: Tracker 836: Add facility to change output file-name for a \book block, pnorcks, 2009/11/03
- Re: Tracker 836: Add facility to change output file-name for a \book block, pnorcks, 2009/11/03
- Re: Tracker 836: Add facility to change output file-name for a \book block, pnorcks, 2009/11/03
- Re: Tracker 836: Add facility to change output file-name for a \book block, Carl . D . Sorensen, 2009/11/03
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block,
ian <=
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/08
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/08
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/09
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/11
- Re: Tracker 836: Add facility to change output file-name for a \book block, Carl . D . Sorensen, 2009/11/11
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/12