|
From: | Michael Käppler |
Subject: | Re: [PATCH] New margin handling - final version (updated) |
Date: | Sat, 12 Sep 2009 00:33:11 +0200 |
User-agent: | Thunderbird 2.0.0.12 (X11/20071114) |
Hi Neil, I'm fine with all your comments...
...however, I don't really understand the benefit of splitting the regtest. Do you propose to have separate files for each combination of settings?The regression test would probably benefit from being split into several separate tests, particularly the final check-consistency setting, which can then have #(ly:set-option 'warning-as-error #f) added to it in anticipation of the mythical time when we can switch this option on for regression testing. :)
And if warning-as-error was set to true, the regtest would fail. I don't think that is intended, since the >absence< of the warning would be wrong behaviour, not the appearance.
Regards, Michael btw. thanks for running the tests.
[Prev in Thread] | Current Thread | [Next in Thread] |