lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix issue 778


From: Patrick McCarty
Subject: Re: [PATCH] Fix issue 778
Date: Thu, 18 Jun 2009 11:15:16 -0700
User-agent: Mutt/1.5.18 (2008-05-17)

On Wed, Jun 17, 2009 at 10:41:24PM +0100, Neil Puttock wrote:
> 2009/6/17 Han-Wen Nienhuys <address@hidden>:
> > I think this can be neater.  By tracking the 'cause property
> > backwards, this could simply be a grob property callback, and the C++
> > does not need to touch the
> > 'dot-count property.
> 
> We already have the callback, as I pointed out in the other thread:
> dots::calc-dot-count.
> 
> Patrick, all you need to do is remove this line, since the callback
> will furnish the correct value for 'dot-count as required:
> 
>       d->set_property ("dot-count", scm_from_int (dur->dot_count ()));
> 
> A regression test would be useful to show that the override actually works.

Okay, thanks for the guidance.  Attached is a revised patch.

Thanks,
-Patrick

Attachment: 0001-Fix-778.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]