Re: [PATCH] Make some local functions public (was: Re: lily-library.scm question)

[Neil Puttock]

2009/6/4 Patrick McCarty <address@hidden>:

> The "print-book-with" procedure is pretty specialized, but I don't see
> any harm in making it public.

It's a helper function for print-book-with-defaults and
print-book-with-defaults-as-systems, so there's no need to make it
public.

-(define (split-at-predicate predicate lst)
+(define-public (split-at-predicate predicate lst)

Can you amend the docstring for this, since the example given is a bit
broken (the cons part shouldn't be there):

(split-at-predicate (lambda (x y) (= (- y x) 2)) '(1 3 5 9 11) (cons '() '()))"

- (define (inner-split predicate lst acc)
+ (define-public (inner-split predicate lst acc)

This can't be public, since it's inside split-at-predicate.

-(define (number->octal-string x)
+(define-public (number->octal-string x)

Is this ever likely to be used?

Regards,
Neil