Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

[Han-Wen Nienhuys]

On Tue, Jun 10, 2008 at 10:42 PM, Neil Puttock <address@hidden> wrote:
> Hi everybody,
>
> Attached is the gist of a patch detailing a fix for Issue 524. Could
> someone check it for me or suggest any improvements so I can push with
> an updated regtest?
>
> There are two things which I'm concerned about:
>
> - it copies some code from accidental-engraver.cc to get the current
> bar number, so I was wondering whether there might be a more efficient
> way for both engravers to get this information (perhaps a Scheme proc
> call?)

the inefficiency of computing things twice is not that important.  I'm
a bit more concerned with duplication of logic, if there is any.  Can
you fold things together into a common function? I think there are a
couple more utility functions for contexts/engravers, so you could add
to that.


> - make_trill should read force-accidental, so that forced accidentals
> can be set using "!" instead of the workaround \once \set
> localKeySignature = #'(). Whilst it's trivial to test for
> force-accidental in the engraver, I'm stumped when it comes to
> transferring the property as part of the trill-span-events in the
> pitchedTrill music function.

it should happen automatically if you set force-accidental on the
corresponding music event in the parser.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen