[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5897 rational: optimize comparison

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• labels: --> Fixed_2_21_1
• status: Started --> Fixed
• Patch: push -->
• Comment:

commit afb5699e1ebd37ccfe6ff4b12c355579d09cc3f2
Author:     Han-Wen Nienhuys <hanwen@lilypond.org>
AuthorDate: Sun Apr 12 18:02:13 2020 +0200
Commit:     Han-Wen Nienhuys <hanwen@lilypond.org>
CommitDate: Fri Apr 17 11:59:04 2020 +0200

    rational: optimize comparison

    calculating sign(left-right) is correct, but requires an unnecessary
    GCD calculation to normalize the result.

    Rational::compare takes about 1% of cumulative time in the carver MDSM
    profile

---

[issues:#5897] rational: optimize comparison

Status: Fixed
Labels: Fixed_2_21_1
Created: Sun Apr 12, 2020 04:03 PM UTC by Han-Wen Nienhuys
Last Updated: Fri Apr 17, 2020 08:11 AM UTC
Owner: Han-Wen Nienhuys

calculating sign(left-right) is correct, but requires an unnecessary
GCD calculation to normalize the result.

Rational::compare takes about 1% of cumulative time in the carver MDSM
profile

https://codereview.appspot.com/559820044

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto