[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5663 Encoding

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: push -->
Comment:

pushed to staging as

commit 13877f0d5eeb0f67381abb3d5e0b250b1ba2afb5
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Wed Jan 15 22:10:35 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Tue Jan 21 20:32:43 2020 +0100

    Issue 5663/3: lilylib: Remove encoded_write

    It&#39;s not needed anymore as sys.stdout and sys.stderr are wrapped
    with encoding writers. (The argument file for show_rules in script
    convert-ly is also sys.stdout.)

commit 5ee6b58300e363762f8c1d9597f360b07a40423e
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Wed Jan 15 16:46:29 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Tue Jan 21 20:32:43 2020 +0100

    Issue 5663/2: musicxml2ly: Correct usage of codecs module

    sys.stdout is already in lilylib and codecs.open() always opens
    a file in binary mode.

commit e0c78a4c710c51e1ea87d2b144c0ae713923a2af
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Wed Jan 15 16:39:56 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Tue Jan 21 20:32:35 2020 +0100

    Issue 5663/1: Use codecs.open() to decode as utf-8

    This is in preparation for Python 3.5 where the default encoding
    depends on the value of the LANG environment variable. As far as
    I can tell, this was changed later on and at least Python 3.7 and
    version 3.8 always default to &#39;utf-8&#39; on Linux. As I&#39;m proposing to
    make Python 3.5 the required minimum, we can&#39;t rely on this and need
    to force &#39;utf-8&#39; when reading files that could contain Unicode.

[issues:#5663] Encoding preparations for Python 3.5

Status: Fixed
Labels: Fixed_2_21_0
Created: Wed Jan 15, 2020 09:42 PM UTC by Jonas Hahnfeld
Last Updated: Tue Jan 21, 2020 04:35 PM UTC
Owner: Jonas Hahnfeld

Encoding preparations for Python 3.5

Use codecs.open() to decode as utf-8

This is in preparation for Python 3.5 where the default encoding
depends on the value of the LANG environment variable. As far as
I can tell, this was changed later on and at least Python 3.7 and
version 3.8 always default to 'utf-8' on Linux. As I'm proposing to
make Python 3.5 the required minimum, we can't rely on this and need
to force 'utf-8' when reading files that could contain Unicode.

musicxml2ly: Correct usage of codecs module

sys.stdout is already in lilylib and codecs.open() always opens
a file in binary mode.

lilylib: Remove encoded_write

It's not needed anymore as sys.stdout and sys.stderr are wrapped
with encoding writers. (The argument file for show_rules in script
convert-ly is also sys.stdout.)

http://codereview.appspot.com/551340043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5663 Encoding preparations for Python 3.5
Date:	Tue, 21 Jan 2020 19:34:53 -0000