[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5597 musicxml: Use method to get number of Lyric

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• Patch: countdown --> push
• Comment:

Jonas, this has been counted down for pushing but please can you asnwer the comment on Rietveld? Otherwise you can push this. If there is still discussion to be had after all then set this back to 'Countdown' (from 'Push') and I can revisit it on the next countdown window.

---

[issues:#5597] musicxml: Use method to get number of Lyric

Status: Started
Created: Thu Nov 07, 2019 09:35 PM UTC by Jonas Hahnfeld
Last Updated: Sat Nov 09, 2019 05:48 PM UTC
Owner: Jonas Hahnfeld

musicxml: Use method to get number of Lyric

Commit edb29ef3a ("Correct an inconsistency in the Lyric class")
renamed the method from get_number() to number(), which is shadowed
by the attribute itself and not used in the current code. Using a
method has the advantage that the code can cast to int() in a single
place which is needed for Python 3. Additionally, the code handles
the case if there is no 'number' attribute (should this ever happen).

http://codereview.appspot.com/573230043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto