Re: [Lilypond-auto] Issue 2379 in lilypond: resetting autoBeaming after a cadenza

[lilypond]

Updates:
        Status: Fixed
        Labels: -Patch-review Fixed_2_17_30

Comment #9 on issue 2379 by address@hidden: resetting autoBeaming after a  
cadenza
http://code.google.com/p/lilypond/issues/detail?id=2379

Ok, I'm having a slight problem here.  The situation that this patch is  
supposed to cure is acerbated by

    Issue 3633: Freeze measurePosition while Timing.timing is off

since now any _difference_ between the grace timing of \cadenzaOn and  
\cadenzaOff will trigger the underlying problem for this patch.  That's  
worse than the original problem that was merely triggered by a grace  
following \cadenzaOff.  The ugly thing about this patch here is that it  
sacrifices measurePosition monotonicity when the main time is frozen while  
the grace time walks on asynchronously.  On the other hand, measurePosition  
is not monotonic across bar boundaries anyway, so chances are that code is  
more or less able to cope.

The alternative solution of keeping measurePosition's grace timing tethered  
to zero leaves less information for beaming and other stuff to work with  
inside of graces.

So I'm pushing this one out in time for 2.17.95 to avoid a regression when  
a cadenza starts with a grace note.  Again, I'm not enthused, but if it  
turns out to be problematic, it won't get cherry-picked into stable.

Test the heck out of this one if you have time/inclination.

Pushed to staging as
commit 838825eb23e874d752c5b6080fd2c7a90ee4014b
Author: David Kastrup <address@hidden>
Date:   Thu Oct 31 12:03:02 2013 +0100

    Issue 2379: resetting autoBeaming after a cadenza

    Letting measurePosition track the grace state of current_moment
    unconditionally keeps it from moving into uncharted territory when
    Timing.timing gets switched on or off during grace times.


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings