[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] mips: Correct and optimize jit_rshr() and jit_rshr_u()
From: |
Paulo César Pereira de Andrade |
Subject: |
Re: [PATCH 1/2] mips: Correct and optimize jit_rshr() and jit_rshr_u() |
Date: |
Wed, 4 Oct 2023 14:50:25 -0300 |
Em ter., 3 de out. de 2023 às 18:41, Paul Cercueil
<paul@crapouillou.net> escreveu:
>
> Le mardi 03 octobre 2023 à 23:36 +0200, Paul Cercueil a écrit :
> > Rework the branch-less path to shrink the size of jit_rshr() and
> > jit_rshr_u(), and use one register less, so that the whole code path
> > that uses branches can be dropped.
> >
> > The case where O4 == __WORDSIZE in jit_rshr() was also handled
> > incorrectly, as it would zero the O1 register instead of sign-
> > extending
> > it.
>
> I notice now that I reference jit_rshr / jit_rshr_u everywhere in this
> commit message, just like I referenced jit_lshr / jit_lshr_u in the
> previous similar commit. I obviously meant jit_qrshr / jit_qrshr_u.
Thanks!
I also changed the aarch64 implementation that can use the same logic.
> -Paul