lightning
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lightning] prolog/leaf requires a prolog_{d, f}/leaf_{d, f} counter


From: Paolo Bonzini
Subject: Re: [Lightning] prolog/leaf requires a prolog_{d, f}/leaf_{d, f} counterpart
Date: Fri, 27 Aug 2010 15:53:09 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

On 08/26/2010 09:15 PM, Paulo César Pereira de Andrade wrote:
   Hi,

   My x86_64 patches to keep stack 16 bytes aligned, in
http://github.com/pcpa/lightning is not fully correct for jit functions, because
it only checks if the number of arguments is odd, before calculating the
stack offset of the first argument.
   This should most times be not an issue, but will be for example if receiving
an odd number of integer/float arguments, and an even number of the other
type, but running out of registers, and needing to put some arguments on
the stack.

   I will implement @subject, matching jit_prepare{,d,f} semantics, but maybe
I am missing something, so, commenting here :-)

Yes, this approach is okay.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]