lightning
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lightning] Re: Updates for x86_64


From: Paulo Cesar Pereira de Andrade
Subject: Re: [Lightning] Re: Updates for x86_64
Date: Tue, 24 Aug 2010 21:23:05 -0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100809 Mandriva/3.1.2-3mdv2011.0 (2011.0) Thunderbird/3.1.2

On 24-08-2010 21:05, Paulo Cesar Pereira de Andrade wrote:

Patch6 extends the features in patch5 to support any number of
integer and float arguments.

But there is still some issue that patch6 does not properly
correct, and the test case

http://code.google.com/p/exl/source/browse/trunk/check/lightning/args.tst

will if checking any float argument. It will not fail if run
under valgrind, or if I call a function other then printf. Either
way, it corrects

https://code.google.com/p/exl/source/browse/trunk/check/lightning/varargs.tst

Patch7 as expected does not correct this issue, but should also
be better added, as it ensures the stack is 16 bytes aligned.

Please review.

Paulo

Attachment: 0007-Ensure-stack-is-aligned-at-16-bytes-when-pushing-ext.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]