lightning
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lightning] Re: PATCH - Correct comparison of float branch test on i386


From: Paolo Bonzini
Subject: [Lightning] Re: PATCH - Correct comparison of float branch test on i386
Date: Wed, 18 Aug 2010 10:04:38 +0200

2010/8/18 Paolo Bonzini <address@hidden>:
> 2010/8/18 Paulo César Pereira de Andrade <address@hidden>:
>>  The macro arguments are always bytes, so, I believe the call to
>> CMPLir must have been a typo.
>>
>>  This allows at least beqr_f (an alias to beqr_d) and beqr_d to
>> work on i386 when compiled with -D_ASM_SAFETY.
>
> Ok, thanks.

Actually, it is better to change the operand to _EAX.  The
AND before guarantees that the current code is correct,
and there's probably a partial register stall if you use a cmpb.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]