[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libunwind-devel] [PATCH 7/7] ppc64: remove compile warnings from wc

From: Cody P Schafer
Subject: Re: [Libunwind-devel] [PATCH 7/7] ppc64: remove compile warnings from wchar test.
Date: Wed, 05 Sep 2012 10:24:46 -0700
User-agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0

On 09/04/2012 11:17 PM, Tommi Rantala wrote:
2012/9/4 Cody P Schafer <address@hidden>:
  tests/ppc64-test-wchar.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

I wonder what the purpose of this test is, any ideas? Why is libunwind
interested in wchar on ppc64? Is this still relevant?
On all of these: no idea.

diff --git a/tests/ppc64-test-wchar.c b/tests/ppc64-test-wchar.c
index 01d637c..4506e7f 100644
--- a/tests/ppc64-test-wchar.c
+++ b/tests/ppc64-test-wchar.c
@@ -1,13 +1,13 @@
  #include <wchar.h>
  #include <stdio.h>
-main ()
+int main ()

I would use "int main (void)".
As would I.

    wchar_t *wstring =

How about "static const wchar_t wstring[] =" while we're at it?
Because I have no idea how that might change what this is testing.

      L"Now is the time for all good men to come to the aid of their country";

reply via email to

[Prev in Thread] Current Thread [Next in Thread]