[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCH 6/6] Fixes for interation end conditions of
From: |
Arun Sharma |
Subject: |
Re: [Libunwind-devel] [PATCH 6/6] Fixes for interation end conditions of non-dwarf walker on x86_64. |
Date: |
Wed, 16 May 2012 08:28:35 -0700 |
On Tue, May 15, 2012 at 3:53 AM, Konstantin Belousov
<address@hidden> wrote:
>> I applied only the first part of this patch.
> It seems that 1a6ea3da607d35c03733b9db26b64b71cdbfcfa7 was applied as a whole.
I forgot to specify the -a flag to git commit --amend.
Reverted the second half now (although with an incorrect commit
message and savannah doesn't let me amend). dwarf_get() is different
from dwarf_step().
>
> I do not understand your note about dwarf_get() returning 0. Isn't dwarf_get()
> API is defined to return 0 on success and (non-zero) UNW_ error on failure ?
Old code was passing through the return value of dwarf_get() (ret=0 =>
success) and the caller was interpreting it as (ret=0 => stop
unwinding).
test-ptrace doesn't fail everywhere as a result of your patch. It
failed for me on Ubuntu 12.04, but passed on Centos5.
This requires a bit more debug. Is this change solving a real world
problem for you?
-Arun