[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libunwind] [PATCH][RESEND] check-ip-cfa-unchanged.patch

From: Arun Sharma (अरुण)
Subject: Re: [libunwind] [PATCH][RESEND] check-ip-cfa-unchanged.patch
Date: Wed, 23 Nov 2005 11:20:36 -0800
User-agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)

Arun Sharma wrote:

update_frame_state: ip and cfa unchanged; stopping here (ip=0x400a5d)

Based on my very limited understanding of how dwarf2 based unwinding
works, the check should be after apply_reg_state?

The patch would be wrong unless c->ip update is also moved to apply_reg_state. It's not clear to me that a separate update_frame_state() is needed for x86-64. So I'm getting rid of it and moving all of the unwinding to apply_reg_state(). Comments?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]