[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tests: fix helldl rule generation in _LT_DEMO_SETUP macr
From: |
Nikolai Merinov |
Subject: |
Re: [PATCH 2/2] tests: fix helldl rule generation in _LT_DEMO_SETUP macro |
Date: |
Sun, 16 Feb 2020 23:02:54 +0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi,
This is gentle reminder about the patch
Regards,
Nikolai
Nikolai Merinov <address@hidden> writes:
> Hi,
>
> Should I make any additional changes to the patch in order to merge it?
>
> Regards,
> Nikolai
>
> On Fri, Mar 15, 2019 at 5:25 PM Nikolai Merinov <address@hidden> wrote:
>
> Hi,
>
> Eric Blake <address@hidden> writes:
>
> > On 3/14/19 5:46 PM, Nikolai Merinov wrote:
> >> * tests/demo.at (_LT_DEMO_SETUP): $@ expanded to empty string during
> >> _LT_DEMO_SETUP expanding. Avoid $@ usage inside m4_define call.
> >
> > It is not necessary to avoid $@, you just merely have to quote it so
> > that m4 doesn't eat it.
> >
> >> ---
> >> tests/demo.at | 15 ++++++++++-----
> >> 1 file changed, 10 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/tests/demo.at b/tests/demo.at
> >> index 4eb156cf..a10520b0 100644
> >> --- a/tests/demo.at
> >> +++ b/tests/demo.at
> >> @@ -121,11 +121,16 @@ else
> >>
> >> # Create a script that says that -dlopen is not supported.
> >> bin_SCRIPTS = helldl
> >> -helldl helldl$(EXEEXT):
> >> - rm -rf $@
> >> - echo '#! /bin/sh' > $@
> >> - echo 'echo sorry, -dlopen is unsupported' >> $@
> >> - chmod +x $@
> >
> > Writing $[@] is generally sufficient to keep m4 from eating things. If
> > that fails, m4sh supports quadrigraphs, where you can write @S|@@ to get
> > $@ in the resulting file.
>
> An additional quotation had had no effect:
>
> $@ --> empty string
> $[@] --> $[@]
> [$@] --> []
>
> But your suggestion with quadrigraph works well. Updated patch attached.
>
> Regards,
> Nikolai
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 2/2] tests: fix helldl rule generation in _LT_DEMO_SETUP macro,
Nikolai Merinov <=