[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix conversion warnings in cwrapper

From: Peter Rosin
Subject: Re: [PATCH] Fix conversion warnings in cwrapper
Date: Mon, 27 May 2013 18:28:23 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6

Hi Yaakov,

On 2013-05-21 08:53, Peter Rosin wrote:
> I have no problem with this patch from a cursory look (haven't tested
> it yet), but I will wait a couple of days with committing it to see
> if Chuck (or someone else for that matter) has something to add.
> Meanwhile, could we please have an update that also zap these lines
> (inside a _MSC_VER #ifdef) as they are no longer needed?
> # ifndef _INTPTR_T_DEFINED
> #  define _INTPTR_T_DEFINED
> #  define intptr_t int
> # endif

Ok, I took the liberty of writing a ChangeLog and removed the above
mentioned lines, as well as changing one unsigned int cast to a
size_t cast, when figured I should double-check your email-address
and realized that you had some previous "tiny changes" under your
belt. Now, these changes are also "tiny", but my understanding is
that you are not allowed more than 10 or so total line edits and
still get away with a "tiny change". You are getting dangerously
close to the limit, and should probably refrain from sending any
more patches w/o a copyright assignment in place. Also, before I
push this, I require a go-ahead from a maintainer.


Attachment: 0001-libtool-fix-conversion-warnings-in-cwrapper.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]