libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libtool: LT_PATH_NM: default to ${ac_tool_prefix}nm


From: Peter Rosin
Subject: Re: [PATCH] libtool: LT_PATH_NM: default to ${ac_tool_prefix}nm
Date: Sun, 28 Apr 2013 09:21:15 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5

On 2013-04-27 22:38, Mike Frysinger wrote:
> On Saturday 27 April 2013 13:53:28 Peter Rosin wrote:
>> On 2013-04-27 07:58, Mike Frysinger wrote:
>>> The current code tries to locate a compatible nm tool.  It starts with
>>> a prefixed nm tool (great!) and includes a plain nm too (that's fine).
>>> The problem is that the code searches for the prefixed nm before the
>>> plain nm (normally fine), but doesn't break once it has found a valid
>>> match.  It does this so that it if it finds an "OK", but "not great",
>>> tool, it'll keep on searching.
>>
>> I agree this sounds like the wrong this to do, but isn't it better to
>> just break all the way out when a "great" nm is found?
> 
> for some reason i thought the [n] arg to break wasn't portable.  this should 
> work though.
> -mike

And on re-reading, my IFS changes are not very constructive. I removed
those. I will push the attached in a couple of days, if there are no
objections.

Cheers,
Peter

Attachment: 0001-libtool-break-all-the-way-out-when-a-good-nm-is-foun.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]