Re: Windows Line Endings

[Roumen Petrov]

Peter Rosin wrote:
> On 2012-10-08 23:29, Roumen Petrov wrote:
> > Peter Rosin wrote:
> > > Hi Roumen,
> > >
> > > On 2012-10-07 11:37, Roumen Petrov wrote:
> > > > And now test fail in cross environment : linux for mingw host
> > > Thanks for the report!
> > >
> > > I have pushed this. Let me know if it doesn't help.
> > No comment.
> Thank you, I'm assuming it finally works for everybody.

Did you think that world to follow you stupid patches ?

It is enough do throw out you commits to bring system in stable state again.

> > Ralf wrote so good code I cannot understand any Peter's  patches.
> > Why you just don not use existing working fine macros ?
> Please, make a useful suggestion instead of hand-waving it like
> that. What working macros should I use? I also don't see where I'm

You even didn't wait  72 hours for feedback !!!!!!!!!

Each of you recent "obvious (!!!!!!!!!!)"  patches break libtool.



> introducing any new macros, can you please point that out for me?
> And Ralf must write very special code indeed if his code somehow
> makes it impossible for some to read the code others write.
> [Ralf, if you're reading this, I hope you understand that I don't
> think that's true, you write very good code, period]
>
>
> In this particular case,
>
>         LT_AT_HOST_DATA([expout],
>
> doesn't work as it creates \r\n newlines in expout, and $EGREP futzes
> the newlines on MSYS so that the standard output ends up \n, causing
> the test to blow up.
>
>         AT_HOST([expout],
>
> doesn't work as $EGREP leaves the newlines alone for Linux->MinGW
> (at least that's what I deduced from your report), and then you
> have \n in expout and \r\n in standard output. And the test blows up.
>
> Either that, or I misread your "And now test fail in cross
> environment : linux for mingw host" message. I read it as if the
> test worked without my patch changing LT_AT_HOST_DATA to AT_HOST,

Exactly .

> and that the test failed with the patch.
Exactly after you fluctuations .

> That message made me
> assume that neither LT_AT_HOST_DATA nor AT_DATA works for this
> test (and the only thing different in this test is that $EGREP
> is used).

You must investigate more why in this particular case LT_AT_HOST_DATA 
fail in you environment .


> So, the newlines has to be normalized after the $EGREP, or the
> test has to be rewritten in a deeper way.

Take care that LT_AT_HOST_DATA is used more then once !


> And, as it happens, Ralf did not write the code I'm changing here,
> it was written by Gary when he thankfully eradicated the legacy
> testsuite, so I'm not sure why you're dragging Ralf into this?
You just wrote to the world that you don't know author of LT_AT_HOST_DATA !

"Ralf did not write the code I'm changing here" - ha ha ha .

You just point  that you lack basic knowledge and experience with 
libtool test suite .

With recent commits you just ask you commit privileges to be revoked due 
lack of background knowledge


Peter, I hop that after 10 years you will reach level of Ralf .

> Cheers,
> Peter

Roumen